Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayPanel: Fixed does not hide after scrolling #13480

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

SoyDiego
Copy link
Contributor

@SoyDiego SoyDiego commented Aug 10, 2023

Fix #13462

Problem

https://stackblitz.com/edit/ppug2d?file=src%2Fapp%2Fdemo%2Foverlay-panel-template-demo.html

If you do scroll clicking the scrollbar inside the overlay panel and then you try to click outside, the overlay panel doesn't close. The menu closes after 2 clicks. (The .GIF doesn't help here, but I'm doing two click outside to close)

overlay panel problem

Solved

After do scroll clicking the scrollbar inside the overlay menu, the overlay panel closes after 1 click.

(The .GIF doesn't help here, but I'm doing one click outside to close)

overlay panel fixed

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 5:28pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Aug 10, 2023 5:28pm

@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test August 10, 2023 17:28 Inactive
@mertsincan
Copy link
Member

Hi @SoyDiego,

Is this.zone.run necessary?

@SoyDiego
Copy link
Contributor Author

Hi @SoyDiego,

Is this.zone.run necessary?

I did this PR 3 weeks ago, there are things that I don't remember, sorry.
But yes. If is there, the code was working with that in that moment.
If you have another better idea, you can send a new commit here in this repo branch too :)

@mertsincan mertsincan merged commit e26b9ee into primefaces:master Aug 29, 2023
@mertsincan
Copy link
Member

No problem, I was just wondering :) After merging it, I can modify it.

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p-overlayPanel does not hide automatically after scrolling
3 participants