Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A maximizable dialog cannot be maximized properly after its size or position has been changed #1888

Closed
jerasa opened this issue Mar 20, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@jerasa
Copy link

jerasa commented Mar 20, 2021

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/6jbh8

Current behavior
A maximizable dialog has a strange behavior after its size or position has been changed:

  • if we change the size of the dialog and then try to maximize it, the maximize action changes just the width of the dialog to full width, but the height remains the same
  • if we drag the dialog to a new position, triggering the maximize action will maximize the dialog but its position will not be aligned with the window but is shifted by the same amount as the non-maximized dialog was moved around. This sometimes leads to situations where part of the dialog is non-reachable/non-visible.

Expected behavior
To be able to have maximized the dialog even after moving it around or changing its size.

  • React version:
    17.0.1

  • PrimeReact version:
    6.2.1

  • Browser:
    all

  • Language:
    ES6/7 | ES5

@mertsincan mertsincan self-assigned this Mar 22, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Mar 22, 2021
@mertsincan mertsincan added this to the 6.2.2 milestone Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants