Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeNode: TypeScript def missing expanded property #2548

Closed
melloware opened this issue Dec 23, 2021 · 0 comments · Fixed by #2549
Closed

TreeNode: TypeScript def missing expanded property #2548

melloware opened this issue Dec 23, 2021 · 0 comments · Fixed by #2549
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
7.2.0

Comments

@melloware
Copy link
Member

melloware commented Dec 23, 2021 •
edited
Loading

I'm submitting a ...

[ x] bug report
  • React version: 17.0.2
  • PrimeReact version: 7.1.0
  • Language: TypeScript

The TreeNode TS is missing the expanded boolean property. I am writing my own custom tree node filtering algorithm and I based it on the current file name based filtering algorithm in the tree component.

I noticed this code:

            if (matched) {
                node.expanded = true;
                return true;
            }

But in TypeScript my code says that expanded is not a valid property of TreeNode.
melloware added a commit to melloware/primereact that referenced this issue Dec 24, 2021
@melloware
Fix primefaces#2548: TreeNode typescript add expanded attribute
51a5d1e
@melloware melloware mentioned this issue Dec 24, 2021
Merged
mertsincan pushed a commit that referenced this issue Jan 19, 2022
@melloware
Fix #2548: TreeNode typescript add expanded attribute (#2549)
75f0783
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 19, 2022
@mertsincan mertsincan added this to the 7.1.1 milestone Jan 19, 2022
@mertsincan mertsincan added Type: Bug Issue contains a defect related to a specific component. and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
7.2.0
Development

Successfully merging a pull request may close this issue.

Fix #2548: TreeNode typescript add expanded attribute melloware/primereact
2 participants
@melloware @mertsincan