Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Definitions incomplete for FileUpload #277

Closed
tsinghammer opened this issue Jan 8, 2018 · 0 comments
Closed

Type Definitions incomplete for FileUpload #277

tsinghammer opened this issue Jan 8, 2018 · 0 comments
Assignees
@Merve7
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
1.4.1

Comments

@tsinghammer
Copy link

Curreently the type definition for the FileUpload component states: onBeforeSend?(): void;
Actually onBevoreSend takes a XHR object, like:

e?: { xhr: XMLHttpRequest, formData: any }

The implementation works fine, it's just the definition.
@Merve7 Merve7 closed this as completed in 8e49027 Jan 8, 2018
@Merve7 Merve7 self-assigned this Jan 8, 2018
@Merve7 Merve7 added the Type: Bug Issue contains a defect related to a specific component. label Jan 8, 2018
@Merve7 Merve7 added this to the 1.4.1 milestone Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merve7 Merve7

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
2 participants
@tsinghammer @Merve7