Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: CellEdit Filtering and NOT_EQUALS #3928

Closed
Jadiction opened this issue Jan 6, 2023 · 4 comments · Fixed by #3929
Closed

DataTable: CellEdit Filtering and NOT_EQUALS #3928

Jadiction opened this issue Jan 6, 2023 · 4 comments · Fixed by #3929
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
9.0.0-beta.1

Comments

@Jadiction
Copy link

Describe the bug

The "Clear" option for Not Equals does not clear the filter when using the column filter feature for DataTables.

Using FilterMatchMode.NOT_EQUALS clears the table data rather than the filtering, no other filters that I've tested seem to have this bug.

Reproducer

https://codesandbox.io/s/primereact-test-forked-ftq5o6

PrimeReact version

8.7.3

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome 108

Steps to reproduce the behavior

  1. Go to the reproducer
  2. Use the top DataTable column filter and select "Not Equals"
  3. Apply with any value then clear it and it will clear the table rather than the filter
    image

Expected behavior

To clear filter rules and not table data.
@Jadiction Jadiction added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 6, 2023
@melloware melloware changed the title Component: DataTable Filtering DataTable: CellEdit Filtering and NOT_EQUALS Jan 6, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 6, 2023
@melloware
Copy link
Member

melloware commented Jan 6, 2023 •
edited
Loading

OK so in this scenario it DOES work: https://codesandbox.io/s/keen-bush-z6wn4y

So I thinking its something specific with Cell Editing or dynamic columns?

@melloware melloware self-assigned this Jan 6, 2023
@melloware melloware added this to the 8.7.4 milestone Jan 6, 2023
melloware added a commit to melloware/primereact that referenced this issue Jan 6, 2023
@melloware
Fix primefaces#3928: FilterService returning no records for NOT_EQUAL…
14dd429 
…S clear
@melloware melloware mentioned this issue Jan 6, 2023
Merged
@Jadiction
Copy link
Author

Looks like you found that quickly!

melloware added a commit that referenced this issue Jan 6, 2023
@melloware
Fix #3928: FilterService returning no records for NOT_EQUALS clear (#…
6773dbb 
…3929)
@melloware
Copy link
Member

Yep fixed it!

@Jadiction
Copy link
Author

Cool! Thanks! Looking forward to 8.7.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Fix #3928: FilterService returning no records for NOT_EQUALS clear melloware/primereact
2 participants
@melloware @Jadiction