Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set csv export filename in DataTable.js using Internet Explorer, it returns undefined.csv #433

Closed
RyanKys opened this issue Jun 4, 2018 · 2 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@RyanKys
Copy link
Contributor

RyanKys commented Jun 4, 2018

[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see

Can reproduce it using IE in demo site:
https://forum.primefaces.org/viewforum.php?f=57

https://plnkr.co/edit/C6qjkdLtbmy92Hogdnjb?p=preview

Current behavior
IE can't define CSV export filename

Expected behavior
Should able to define filename similar to Chrome

  • PrimeReact version:
    1.5.2

  • Browser: [Affect IE only]

@RyanKys
Copy link
Contributor Author

RyanKys commented Jun 4, 2018

As I mentioned in the primefaces forum, the issue is due to a bug in DataTable.js:

if(windows.navigator.msSaveOrOpenBlob){
navigator.msSaveOrOpenBlog(blob,this.exportFilename+ '.csv');
}

it should be "this.props.exportFilename"

@mertsincan
Copy link
Member

Thanks a lot for the PR!

@mertsincan mertsincan self-assigned this Jun 4, 2018
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jun 4, 2018
@mertsincan mertsincan added this to the 1.6.0 milestone Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants