Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollPanel: Default scroll bars start to appear when zooming out with the browser #4660

Closed
ThomDevine opened this issue Jul 17, 2023 · 6 comments · Fixed by #4743
Closed
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@ThomDevine
Copy link

Describe the bug

The further I shrink the browser zoom, the more some browser-default scrollbars appear in the ScrollPanel. Viewable on the ScrollPanel demo page.

While researching the issue to see if other scroll panel libraries are affected by it, I came across this one which had the same problem reported, and was able to fix it: sakhnyuk/rc-scrollbars#15 Their panel structure looks pretty similar to how PrimeReact's is built.

Reproducer

https://primereact.org/scrollpanel/

PrimeReact version

9.3.1

React version

17.x

Language

ES5

Build / Runtime

Vite

Browser(s)

Chrome 114, FIrefox 114

Steps to reproduce the behavior

  1. Go to the ScrollPanel Demo page: https://primereact.org/scrollpanel/
  2. Zoom out using browser zoom

On my machine, the bars start to appear at 80% as tiny strips, and keep "growing" the more I zoom out.

Expected behavior

Only the scroll bar styled by ScrollPanel should be displayed.

@ThomDevine ThomDevine added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 17, 2023
@SoyDiego
Copy link
Contributor

SoyDiego commented Aug 2, 2023

@ThomDevine Can you post a screenshot or something to show the problem. I did the steps, but I cannot see the problem.

@ThomDevine
Copy link
Author

ThomDevine commented Aug 2, 2023

I sure can, thanks for investigating! Both screenshots come from viewing the ScrollPanel doc page in Chrome.

67% zoom:
image

50% zoom:
image

My Windows desktop zoom is set to 125%, which may affect how the issue presents; we've seen different desktop zoom levels affect browser zoom behavior before.

@SoyDiego
Copy link
Contributor

SoyDiego commented Aug 3, 2023

I sure can, thanks for investigating! Both screenshots come from viewing the ScrollPanel doc page in Chrome.

67% zoom: image

50% zoom: image

My Windows desktop zoom is set to 125%, which may affect how the issue presents; we've seen different desktop zoom levels affect browser zoom behavior before.

Thanks for your screenshot. I will try to check later ^^

@SoyDiego
Copy link
Contributor

SoyDiego commented Aug 4, 2023

Hi @ThomDevine. I think I solved the problem. Ihave created a PR.
You can check here #4743.
Now we should wait the PrimeReact Team (@habubey) approve it if it's ok for them :)

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 4, 2023
@melloware melloware added this to the 10.0.0 milestone Aug 4, 2023
@ThomDevine
Copy link
Author

Thanks @SoyDiego ! I laughed out loud when I saw what the fix was. It's the classic case of "99% of solving the problem is knowing where to look" 😄

@SoyDiego
Copy link
Contributor

SoyDiego commented Aug 4, 2023

Thanks @SoyDiego ! I laughed out loud when I saw what the fix was. It's the classic case of "99% of solving the problem is knowing where to look" 😄

haha no problem! happy to help :)

@melloware melloware modified the milestones: 10.0.0, 9.7.0 Aug 22, 2023
@melloware melloware modified the milestones: 9.7.0, 10.0.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants