-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputText: Typescript useRef types with new const instead of class components #6336
Comments
@dvpritzbuer can you wait until the next release I am pretty sure all of your issues you are reporting are already fixed. |
I mean my first issue today was not already fixed and why shouldn't you take my free feedback even if you just tag it with fixed in 10.6.3? And this issue here is valid for all new components that use const instead of class (also tested it for IconField) and not only the Stepper! But ok.. at least in short notice my other bugs as comment:
|
IconField already fixed: #6271 What I was saying was in |
Yeah that's fine, but it's a lot easier for me to just post an issue report instead of searching the code for possible fixes. |
i think this week sometime. I don't work for PrimeTek... |
Hi there, |
Hi, With release 10.6.3 the issue should be fixed. If you notice that the issue persists, please ping me. |
@gucal Also I recognized the original ticket description is not correct since Stepper doesn't have a ref and I just tested it initially with this component since this is a new const type definition. I have no perfect solution here for you since it would either require the user to write more code or to import another type. But it would work with this line: So either the user always writes this line himself if using refs within typescript or you export another type like Maybe you find a better solution here? |
Reopened and changed the title. |
Ah sorry, I got confused by changing the types within PR #6356 and Stepper not having any ref definition yet, but of course the Stepper also has a ref and the initial title was valid 😅 |
@dvpritzbuer i am confused where are we at with this ticket as of 10.6.5? |
Describe the bug
const ref = useRef<Stepper>(null);
--> "'Stepper' refers to a value, but is being used as a type here. Did you mean 'typeof Stepper'?"const ref = useRef<Panel>(null);
--> works fineReproducer
https://stackblitz.com/edit/vitejs-vite-osrp8p?file=src%2FApp.tsx,package.json
PrimeReact version
10.6.2
React version
18.x
Language
TypeScript
Build / Runtime
Vite
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response
The text was updated successfully, but these errors were encountered: