Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Some types in CalendarPassThroughOptions are wrong #6675

Closed
ivanpajon opened this issue May 26, 2024 · 0 comments · Fixed by #6676
Closed

Calendar: Some types in CalendarPassThroughOptions are wrong #6675

ivanpajon opened this issue May 26, 2024 · 0 comments · Fixed by #6676
Assignees
@ivanpajon
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.7.0

Comments

@ivanpajon
Copy link
Contributor

Describe the bug

Some types in CalendarPassThroughOptions are wrong defined (input, dropdownButton, todayButton and clearButton), and when you try to use the calendar props in unstyled mode (and typescript), most are undefined due to this.

Reproducer

No response

PrimeReact version

10.6.6

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Using calendar props in unstyled mode not resulting in getting undefined.
@ivanpajon ivanpajon added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 26, 2024
@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 26, 2024
@melloware melloware added this to the 10.7.0 milestone May 26, 2024
@ivanpajon ivanpajon mentioned this issue May 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanpajon ivanpajon

Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.7.0
Development

Successfully merging a pull request may close this issue.

fix: Types in CalendarPassThroughOptions ivanpajon/primereact
2 participants
@melloware @ivanpajon