Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc say DataTable editMode default is "cell" but its Null #6691

Closed
ykimhi opened this issue May 28, 2024 · 3 comments · Fixed by #6692, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Closed

Doc say DataTable editMode default is "cell" but its Null #6691

ykimhi opened this issue May 28, 2024 · 3 comments · Fixed by #6692, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Assignees
@Rekl0w
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
10.7.0

Comments

@ykimhi
Copy link

ykimhi commented May 28, 2024

Doc:
https://primereact.org/datatable/#api.DataTable.props.editMode

Code:
https://github.com/primefaces/primereact/blob/063c100193ebdd8518b143fa34f962ed21e69ba8/components/lib/datatable/DataTableBase.js#L444C9-L444C24
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 28, 2024
@Rekl0w Rekl0w mentioned this issue May 28, 2024
Merged
@Rekl0w
Copy link
Contributor

Rekl0w commented May 28, 2024

PR submitted.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 28, 2024
@melloware melloware added this to the 10.7.0 milestone May 28, 2024
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Type: Bug Issue contains a defect related to a specific component. labels May 28, 2024
@melloware
Copy link
Member

Wait but if it defaults to cell wouldn't that make all tables Cell Edit by default now? I think the docs should be updated to say "default null"

@Rekl0w
Copy link
Contributor

Rekl0w commented May 28, 2024

Makes more sense. I'll update it @melloware

melloware added a commit that referenced this issue May 28, 2024
@Rekl0w @melloware
Fix #6691: fix default editMode value (#6692)
da6ce28 
* Fix #6691: fix default editMode value

* Revert "Fix #6691: fix default editMode value"

This reverts commit 73b94a9.

* Fix #6691: update docs

* Update datatable.d.ts

---------

Co-authored-by: Melloware <mellowaredev@gmail.com>
@nhattpn nhattpn mentioned this issue Jul 25, 2024
Open
@leoo1992 leoo1992 mentioned this issue Jul 25, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rekl0w Rekl0w

Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
10.7.0
3 participants
@melloware @ykimhi @Rekl0w