Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: I double-click outside to close the calendar after selecting the range. #6920

Closed
KumJungMin opened this issue Jul 24, 2024 · 4 comments · Fixed by #6921
Closed
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@KumJungMin
Copy link
Contributor

Describe the bug

I selected a range on the calendar and the calendar will automatically close.
In this state, open the calendar again.
And In order to close the calendar, i tried to click outside the calendar once.

However, contrary to expectations, i need to double-click to close the calendar.
This issue occurs only once after selecting a range on the calendar.

2024-07-24.9.18.54.mov

Reproducer

https://stackblitz.com/run?file=src%2FApp.jsx

PrimeReact version

master

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Select a range on the calendar. The calendar window will automatically close.
  2. Then, open the calendar again.
  3. To close the calendar, click outside of the calendar, but it will not close. In this case, double-clicking outside the calendar will close it.
  4. This issue occurs only once after selecting a range.

Expected behavior

Assume that a range has been selected on the calendar.
Then, when you open the calendar again and click outside of it, the calendar should be close immediately.

@KumJungMin KumJungMin added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 24, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 24, 2024
@melloware melloware added this to the 10.7.1 milestone Jul 24, 2024
@lkuich
Copy link

lkuich commented Oct 10, 2024

@melloware I'm still seeing this issue as of 10.7.1, and it looks like it was introduced as of 10.5.1:

<Calendar value={dates} onChange={(e) => setDates(e.value)} selectionMode="range" hideOnRangeSelection={false} />
  1. Click the Calendar
  2. Select a range
  3. Click outside of the Calendar, and observe it doesn't close
  4. Click outside of the Calendar again and observe it does close

I was able to get around this by reverting to 10.5.0. I suspected it was to do with this change, but can't see why that would be an issue: #5971

@melloware
Copy link
Member

@KumJungMin care to investigate?

@KumJungMin
Copy link
Contributor Author

KumJungMin commented Oct 11, 2024

@KumJungMin care to investigate?


Sure, I’m interested in looking into it :) (I will check it by October 14th at the latest.)

@KumJungMin
Copy link
Contributor Author

KumJungMin commented Oct 14, 2024

First of all, Thank you for re-verifying the bug and my code doesn't work as you expected.
I didn't test the case properly. This is my mistake :(
I will be more mindful in my work moving forward.
(I will request a PR to delete my code)

Why the Issue Occurred in v10.5.2?

  • I checked versions v10.5.0, v10.5.1, and v10.5.2 to investigate the root cause of the issue.
  • As a result, I found that the double-click issue in the calendar was introduced by this change.
  • If you remove type: 'mousedown', the calendar will close on the first click.

Problematic code snippet (Calendar.js)
Code snippet causing the issue


The Issue Resolved?

  • Additionally, I checked "Calendar double click issue" on the master(maybe v10.8.4) branch.
  • After another PR was merged into the master branch,
  • As a result, the issue does not occur in v10.8.4 :)

Related code snippet (Calendar.js)
스크린샷 2024-10-14 오후 8 21 56


If I misunderstood something or if you have further questions, feel free to leave a comment! :) @lkuich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
3 participants