Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Listing as bullet display as numbered #6993

Closed
swotiendang opened this issue Aug 6, 2024 · 7 comments · Fixed by #7004
Closed

Editor: Listing as bullet display as numbered #6993

swotiendang opened this issue Aug 6, 2024 · 7 comments · Fixed by #7004
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@swotiendang
Copy link
Contributor

Describe the bug

https://primereact.org/editor/
Listing items as bullet but display numbered.

image

Reproducer

No response

System Information

Chrome: v127 latest
"primeflex": "^3.3.1",
"primeicons": "^7.0.0",
"primereact": "^10.8.2",

Steps to reproduce the behavior

No response

Expected behavior

Display bullet for Editor when hitting Unordered list

@swotiendang swotiendang added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 6, 2024
@melloware
Copy link
Member

Duplicate of #6914

its a bug in QuillJS: slab/quill#4124 Please track that issue.

@melloware melloware added Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

This issue is a duplicate and has already been reported and possibly fixed. Please review other issues both open and closed for a similar issue to this one.

@swotiendang
Copy link
Contributor Author

swotiendang commented Aug 7, 2024

Hi @melloware , this is my finding, I believe in primereact Editor implementation ignore core.css of Quills, there is many changes between quills@1.3.7 and quills@2.0.2

image

This is my suggestion, do import quill.snow.css or quill.core.css to primereact Editor v10.8.2, I don't see such import in current latest version. I'm afraid Quills will not care our issue since their side works fine

@swotiendang
Copy link
Contributor Author

swotiendang commented Aug 7, 2024

Correct me if I'm wrong, we are using quill v1.3.7 css in usage of quill@2.0.0
https://github.com/primefaces/primereact/blob/master/components/lib/editor/EditorBase.js

@melloware
Copy link
Member

PrimeReact after 10.6.4 requires Quill 2.0 see: #5960

Previous to that it was 1.3.7

@melloware melloware removed the Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted label Aug 7, 2024
@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Aug 7, 2024
@melloware melloware added this to the 10.8.3 milestone Aug 7, 2024
@swotiendang
Copy link
Contributor Author

Hi @melloware , I need to bring this change to my project for version @10.8.2, my side do not allow more delay for the release.
I'm trying to build the primereact and copy the build src to my project using npm patch package, but I cannot build it.

image

Command I use: build:package
Environment: Window 11 Pro

I suggest to create a section in the documentation to show how to build and bundle the project.

@melloware
Copy link
Member

You want npm run build:lib to build the whole library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants