Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpeedDial : Fix aria-controls values #7110

Closed
kyybo opened this issue Sep 4, 2024 · 1 comment · Fixed by #7111
Closed

SpeedDial : Fix aria-controls values #7110

kyybo opened this issue Sep 4, 2024 · 1 comment · Fixed by #7111
Assignees
@kyybo
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
10.8.3

Comments

@kyybo
Copy link
Contributor

kyybo commented Sep 4, 2024

Describe the bug

"The aria-controls attribute identifies the element (or elements) whose contents or presence are controlled by the element on which the attribute is set" (--> https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls)

The aria-controls attribute should only be placed on the SpeedDial trigger button. And its value must be the identifier or list of identifiers of its items.

Current behavior :
image

Reproducer

No response

System Information

"primereact": "10.8.2"
"react": "^18.2.0"

Steps to reproduce the behavior

No response

Expected behavior

The aria-controls value should be an actual id (or a list of ids)

image
@kyybo kyybo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 4, 2024
@kyybo kyybo mentioned this issue Sep 4, 2024
Merged
@kyybo
Copy link
Contributor Author

kyybo commented Sep 4, 2024

PR : #7111

@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 4, 2024
@melloware melloware added this to the 10.8.3 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyybo kyybo

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
10.8.3
Development

Successfully merging a pull request may close this issue.

Fix #7110 - SpeedDial : Fix aria-controls values kyybo/primereact
2 participants
@melloware @kyybo