Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expandIcon and collapseIcon props to Panel component #888

Closed
JOSE89 opened this issue May 16, 2019 · 6 comments
Closed

Add expandIcon and collapseIcon props to Panel component #888

JOSE89 opened this issue May 16, 2019 · 6 comments
Assignees
@mertsincan
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
3.1.4

Comments

@JOSE89
Copy link

JOSE89 commented May 16, 2019

I'm submitting a ... (check one with "x")

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
Component panel only has the pi pi-minus and pi pi-plus icons to expand and collapse.

Expected behavior
We need an attribute in the panel component to change the expand/collapse icons.

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@TonisPiip
Copy link
Contributor

This sounds quite simple, maybe fork and make a PR?

@JOSE89
Copy link
Author

JOSE89 commented May 17, 2019

I've done the PR!

@TonisPiip TonisPiip mentioned this issue May 17, 2019
Closed
@JOSE89
Copy link
Author

JOSE89 commented May 17, 2019

PR Panel Icons without spaces #893

@mertsincan mertsincan changed the title Icon panel Add expandIcon and collapseIcon props to Panel component May 21, 2019
@mertsincan mertsincan self-assigned this May 21, 2019
@mertsincan mertsincan added the Type: New Feature Issue contains a new feature or new component request label May 21, 2019
@mertsincan mertsincan added this to the 3.1.4 milestone May 21, 2019
@mertsincan
Copy link
Member

Hi @JOSE89 and @CylonOven,
Thanks a lot for the PRs. I made some changes to fix this issue.

Thanks again.
Best Regards,

@TonisPiip
Copy link
Contributor

There is still an open PR for this issue that should be closed.

@mertsincan
Copy link
Member

Thanks a lot for the update!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
3.1.4
Development

No branches or pull requests
3 participants
@TonisPiip @JOSE89 @mertsincan