-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Datatable radiobuttons and types #6698
Fix: Datatable radiobuttons and types #6698
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to update index.json you should update the .d.ts file and it gets autogenerated from the TypeScript files.
See "npm run build:api" script in package.json |
In fact I didn't manually change any the index.json, but after running npm run dev:link:windows and making the changes that file was auto generated. |
Hmm OK i didn't see you had updated |
@nitrogenous this looks great to me but wanted you to review also. |
Seems fine but we are currently working on some structural updates let me also check is there any conflicts with our current tasks. Appreciate it @melloware |
Defect Fixes
Fix #6697
I fix the behavior of radiobuttons in datatable so they can be styled through PT, and although I don't even know what ptm, ptmo, cx, sx functions mean and do... I figured out what they did and managed to make it work. So please, if there is a cleaner way or a 'Prime React' way you usually use, feel free to make the necessary changes.
Changes made:
Using the same example used to reproduce the bug you can see the result:
Table "Deafult unstyled values" not working:
Fixed table "Fixed unstyled values":
Example of PrimeReact documentation:
ONLY RADIOBUTTONS, DON'T COMPARE REST OF STYLES