From cb53f4fa94e5edaa183ba572387f63da1d2afe2b Mon Sep 17 00:00:00 2001 From: Paschalis Economou Date: Mon, 1 Jul 2024 13:09:28 +0200 Subject: [PATCH 1/3] apidoc changes as a result of build --- components/doc/common/apidoc/index.json | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/components/doc/common/apidoc/index.json b/components/doc/common/apidoc/index.json index 695698ff40..32d603b0a4 100644 --- a/components/doc/common/apidoc/index.json +++ b/components/doc/common/apidoc/index.json @@ -562,9 +562,8 @@ "type": "PrimeReactProviderProps" }, { - "name": "deprecatedLegacyContext", - "type": "any", - "description": "" + "name": "context", + "type": "any" } ], "returnType": "ReactNode" From dee5fd99f70487f52bf80775224dd3d8bcea8081 Mon Sep 17 00:00:00 2001 From: Paschalis Economou Date: Mon, 1 Jul 2024 13:10:11 +0200 Subject: [PATCH 2/3] add comment regarding Javascript heap error, to help developers during local testing --- DEVELOPMENT.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 4e3e06d424..c17ea50a1f 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -23,8 +23,9 @@ C:\primereact> npm run dev:link:windows This will alter the bundler to only emit non-minified esm modules. The aliasing plugin has also been disabled for components. Once everything has been bundled (this can take a few minutes) you should keep this command running. It will allow for incremental builds as you develop in the `primereact/` directory. -> [!NOTE] -> It will be finished when the terminal displays: `[20xx-xx-xx 00:00:00] waiting for changes...`. +> Note: if you get "Error: JavaScript heap out of memory", it may help to set the following node variable: `export NODE_OPTIONS=--max-old-space-size=8192`. + +> Note: The build will be finished when the terminal displays: `[20xx-xx-xx 00:00:00] waiting for changes...`. You will now `cd` into the `primereact/dist` directory and run: From 0aa9e41e5914210c679d037588805682a3cedc2e Mon Sep 17 00:00:00 2001 From: Paschalis Economou Date: Mon, 1 Jul 2024 13:10:29 +0200 Subject: [PATCH 3/3] make sure editable dropdown opens when user types --- components/lib/dropdown/Dropdown.js | 1 + 1 file changed, 1 insertion(+) diff --git a/components/lib/dropdown/Dropdown.js b/components/lib/dropdown/Dropdown.js index 4c0bee669b..c3a6387d18 100644 --- a/components/lib/dropdown/Dropdown.js +++ b/components/lib/dropdown/Dropdown.js @@ -654,6 +654,7 @@ export const Dropdown = React.memo( }; const onEditableInputChange = (event) => { + !overlayVisibleState && show(); let searchIndex = null; if (event.target.value && visibleOptions) {