Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primary button focus ring missing for mytheme #54

Open
bobby-driggs opened this issue Jan 26, 2024 · 0 comments
Open

primary button focus ring missing for mytheme #54

bobby-driggs opened this issue Jan 26, 2024 · 0 comments

Comments

@bobby-driggs
Copy link

bobby-driggs commented Jan 26, 2024

Not sure if this is a bug or not.

I just updated to version 3.47.2 (from 3.44.0), and now my primary buttons don't have a focus ring when they are pressed (has the :focus state active), but the Secondary, Info, Warning, etc buttons still do.

They have the SCSS like below inside the theme-base\components\button\_button.scss file

    &:not(:disabled):focus {
        box-shadow: $secondaryButtonFocusShadow;
    }

I noticed that the non-primary buttons have rules that target the :focus state, but the primary button does not have this rule. It looks like this commit changed it to be :focus-visible : 08026c0

Flipping around the themes on https://primevue.org/button/ it looks like the Aura themes do not have this focus ring, but the Lara theme does.

It seems like the mytheme editable base is maybe broken? Or is the intent to manually set the focus ring for the primary button when using the mytheme ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant