Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable cell editing regression #1357

Closed
blurbiness opened this issue Jun 22, 2021 · 2 comments
Closed

DataTable cell editing regression #1357

blurbiness opened this issue Jun 22, 2021 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@blurbiness
Copy link

DataTable in cell editing is not working properly in 3.5.1.
It seems that row index provided in editor slot props is not correct.

Error is reproduced in the showcase page, Advanced Cell Editing sample:
https://primefaces.org/primevue/showcase/#/datatable/edit
If a cell is edited and then Enter or Tab is pressed, edited value is lost.

In a working app where the same approach as Advenced Cell Editing example had been adopted, I had detected that the row index provided in <template #editor="slotProps"> was not correct. Same code without any modification worked as expected up to 3.4.0.

@nclemeur
Copy link

I haven't tested but too me it look like the fix for #1274 (see
here) was a bit lazy and did not look pass the next line

@tugcekucukoglu tugcekucukoglu changed the title DataTable in cell editing not working properly in 3.5.1 DataTable cell editing regression Jun 23, 2021
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable labels Jun 23, 2021
@tugcekucukoglu tugcekucukoglu added this to the 3.5.2 milestone Jun 23, 2021
@tugcekucukoglu tugcekucukoglu self-assigned this Jun 23, 2021
@tugcekucukoglu
Copy link
Member

It is a regression.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants