Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable column width increases by content limitlessly #1573

Closed
ibrdavid opened this issue Sep 21, 2021 · 5 comments
Closed

DataTable column width increases by content limitlessly #1573

ibrdavid opened this issue Sep 21, 2021 · 5 comments

Comments

@ibrdavid
Copy link

Due to the fixes of #1508 and #1521, you made a change in DataTable.vue from

.p-datatable table {
    border-collapse: collapse;
    width: 100%;
    table-layout: fixed;
}

to

.p-datatable table {
    border-collapse: collapse;
    min-width: 100%;
    table-layout: fixed;
}

This change leads to columns, whose width will increase by their content limitlessly:

falsch

The former definition gave each column the same width, despite of their content:

richtig

PrimeVue: 3.7.2
Vue: 3.2.11

@mertsincan
Copy link
Member

Hi,

I couldn't replicate this issue. Could you please attach a codesanbox link for us to replicate?

@mertsincan mertsincan self-assigned this Sep 21, 2021
@ibrdavid
Copy link
Author

This codesandbox uses PrimeVue 3.7.2:
https://codesandbox.io/s/blissful-sea-6c060

If you edit package.json and change dependencies.primevue to "3.7.1", you'll get the original and desired result.

@cagataycivici cagataycivici added this to the 3.8.2 milestone Oct 25, 2021
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 25, 2021
@cagataycivici cagataycivici modified the milestones: 3.8.2, 3.8.3 Oct 25, 2021
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Oct 25, 2021
@cagataycivici
Copy link
Member

Seems like a regression, we'll see if there is anything we can do. min-width should stay though.

@cagataycivici
Copy link
Member

Current solution with 3.8.2 is tableStyle="width:100%"

#1696

@cagataycivici cagataycivici modified the milestones: 3.9.0, 3.10.0 Nov 17, 2021
@mertsincan mertsincan modified the milestones: 3.10.0, 3.x Dec 7, 2021
@tugcekucukoglu
Copy link
Member

Could you please try to use the latest PrimeVue version? If the problem still persists, please create a new issue with a reproducer link.

@tugcekucukoglu tugcekucukoglu removed this from the 3.x milestone Apr 12, 2023
@tugcekucukoglu tugcekucukoglu removed the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants