Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullCalendar: Deprecated component #3827

Closed
tugcekucukoglu opened this issue Mar 31, 2023 · 11 comments
Closed

FullCalendar: Deprecated component #3827

tugcekucukoglu opened this issue Mar 31, 2023 · 11 comments
Assignees
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Breaking Change Issue contains a breaking change related to a specific component Type: Deprecated Issue contains a deprecated component. The component will be removed in any future release
Milestone

Comments

@tugcekucukoglu
Copy link
Member

No description provided.

@tugcekucukoglu tugcekucukoglu added this to the 3.27.0 milestone Mar 31, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Mar 31, 2023
@tugcekucukoglu tugcekucukoglu added Type: Breaking Change Issue contains a breaking change related to a specific component Core Team Issue or pull request has been *opened* by a member of Core Team labels Mar 31, 2023
@tugcekucukoglu tugcekucukoglu added the Type: Deprecated Issue contains a deprecated component. The component will be removed in any future release label Mar 31, 2023
@simon-davey
Copy link

Hi @tugcekucukoglu,

Can you give us some more information on this breaking change, please. Specifically, why is this component being deprecated and will there be an alternative calendar UI (fully featured rather than the date-picker calendar) added in 3.27?

@tugcekucukoglu
Copy link
Member Author

PrimeVue supported theming for FullCalendar and is now withdrawing it. We are also planning to create PrimeVue calendar alongside date picker.

@simon-davey
Copy link

simon-davey commented Apr 12, 2023

Would it be possible to mark the component as deprecated but not actually remove it until the PrimeVue calendar is released?
Removing it before the PrimeVue calendar is ready will block users from upgrading to 3.27

@ineshbose
Copy link
Contributor

I've upgraded to 3.27 as well but as using FullCalendar in my app, so I need to downgrade - I know a replacement is planned for Q3, but till then the component should be deprecated and not actually removed (both are different!)

@arnyee
Copy link

arnyee commented Apr 25, 2023

Can you take back Fullcalendar or please show u what is the new actual component

@Ancient-Dragon
Copy link
Contributor

Would it be possible to mark the component as deprecated but not actually remove it until the PrimeVue calendar is released? Removing it before the PrimeVue calendar is ready will block users from upgrading to 3.27

I agree with this, it should be marked as deprecated but still usable to allow people the time to migrate off rather than blocking people from upgrading.

@Peter-J-Brown
Copy link

I'd like the echo the comments above, a transition period between deprecation and outright removal would have been appreciated here

@arnyee
Copy link

arnyee commented May 2, 2023

@tugcekucukoglu Please can you give us a solution here? What we need to use?

@ineshbose
Copy link
Contributor

I copied contents from https://github.com/primefaces/primevue/blob/ac87f9a5d568f9ae413879a87a7bed6417a2f1fa/components/lib/fullcalendar/FullCalendar.vue and added it to my app as a workaround.

@arnyee
Copy link

arnyee commented May 2, 2023

Very nice solution @ineshbose Thx mate

@joaopaulocruz
Copy link

joaopaulocruz commented Jul 10, 2023

Just change

import FullCalendar from "primevue/fullcalendar"

to

import FullCalendar from "@fullcalendar/vue3"

and add on options

events: getEventsFromSomeWhere(),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Breaking Change Issue contains a breaking change related to a specific component Type: Deprecated Issue contains a deprecated component. The component will be removed in any future release
Projects
None yet
Development

No branches or pull requests

7 participants