Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber with dynamic fraction digits doesn't work as expected #455

Closed
Rakasch opened this issue Aug 28, 2020 · 4 comments
Closed

InputNumber with dynamic fraction digits doesn't work as expected #455

Rakasch opened this issue Aug 28, 2020 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Rakasch
Copy link
Contributor

Rakasch commented Aug 28, 2020

Since the upgrade to 2.0.8 I can no longer enter decimal places.
It always stays at xx,00.
The zeros cannot be overwritten.
If you delete a 0, it will be autocompleted again immediately.
Maybe #432 has broken something here.

@mertsincan
Copy link
Member

Unfortunately, I couldn't replicate this issue in https://primefaces.org/primevue/showcase/#/inputnumber
What steps should I follow to replicate it?

@Rakasch
Copy link
Contributor Author

Rakasch commented Aug 28, 2020

The reason in my example is that the value for minFractionDigits and maxFractionDigits can change here.
If the value of fraction_digits is first set to 0 and later changed to 2, you can see the decimal places in the NumberInput field, but you cannot write them.

numberinput_fractiondigits_example.txt

Looks like this did not work in 2.0.7 either.
I guess my memory was wrong.

@mertsincan mertsincan changed the title InputNumber with decimals - cant enter any decimals InputNumber with dynamic fraction digits doesn't work as expected Sep 1, 2020
@mertsincan mertsincan self-assigned this Sep 1, 2020
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 1, 2020
@mertsincan mertsincan added this to the 2.0.9 milestone Sep 1, 2020
@mertsincan
Copy link
Member

Thanks a lot for the sample code! Fixed now.

Best Regards,

@abhijeetj100
Copy link

Hey guys, newbie here!
So following the docs I got primevue v2.0.0, which now I am realizing is too old. To overcome this issue, I need to update to 2.0.9 ?

CC: @mertsincan

Thanks,
Abhijeet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants