Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumber: Support roundingMode for the InputNumber #4945

Closed
trandaison opened this issue Dec 8, 2023 · 1 comment · Fixed by #4946
Closed

InputNumber: Support roundingMode for the InputNumber #4945

trandaison opened this issue Dec 8, 2023 · 1 comment · Fixed by #4946
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.45.0

Comments

@trandaison
Copy link
Contributor

Describe the bug

Since InputNumber is using Intl.NumberFormat for formating the value.
There are some options are not supported, such as roundingMode.

How about adding the roundingMode prop for the InputNumber?

Reproducer

N/A

PrimeVue version

2.10.4

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@trandaison trandaison added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 8, 2023
@trandaison trandaison mentioned this issue Dec 8, 2023
Merged
@trandaison
Copy link
Contributor Author

I also create an issue and a PR for the ReactPrime repo.

@mertsincan mertsincan added Type: New Feature Issue contains a new feature or new component request Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Dec 22, 2023
@mertsincan mertsincan added this to the 3.45.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.45.0
Development

Successfully merging a pull request may close this issue.

Support roundingMode for InputNumber trandaison/primevue
2 participants
@mertsincan @trandaison