Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepList and StepPanels: Different type than of Stepper, Step and StepPanel #6059

Closed
julichan opened this issue Jul 14, 2024 · 0 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@julichan
Copy link

julichan commented Jul 14, 2024

Describe the bug

The type of the value parameter on StepList and StepPanels is only string while it is string | number on Stepper, Step and StepPanel.
In exemple this "value" parameter on StepList and StepPanels seems optional and not used but typescript complains it is mandatory and cannot be a number.
I believe this problem was introduced in RC2 or RC3.

Reproducer

No stackblitz necessary

PrimeVue version

4.0.0

Vue version

4.x

Language

TypeScript

Build / Runtime

TypeScript

Browser(s)

Irrevelant since it's a typescript validation problem

Steps to reproduce the behavior

No response

Expected behavior

The parameter types match in all the Stepper component and number is usable so that numerical comparison and enums can be properly used as steps. numerical comparisons are helpful to determine available steps.

@julichan julichan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 14, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 31, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.4 milestone Jul 31, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants