Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: Could not resolve "valibot" #6708

Closed
25Das opened this issue Nov 1, 2024 · 2 comments
Closed

Forms: Could not resolve "valibot" #6708

25Das opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels
Package: Forms name: @primevue/forms Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@25Das
Copy link

25Das commented Nov 1, 2024

Describe the bug

X [ERROR] Could not resolve "valibot"

node_modules/@primeuix/forms/resolvers/valibot/index.mjs:4:54:
  4 │ import { getDotPath, safeParse, safeParseAsync } from "valibot";
    ╵                                                       ~~~~~~~~~

You can mark the path "valibot" as external to exclude it from the bundle, which will remove this
error and leave the unresolved path in the bundle.

ERROR error while updating dependencies: 12:01:49
Error: Build failed with 1 error:
node_modules/@primeuix/forms/resolvers/valibot/index.mjs:4:54: ERROR: Could not resolve "valibot"
at failureErrorWithLog (C:\www\stabilite\stabilite-tauri\node_modules\vite\node_modules\esbuild\lib\main.js:1472:15)
at C:\www\stabilite\stabilite-tauri\node_modules\vite\node_modules\esbuild\lib\main.js:945:25
at C:\www\stabilite\stabilite-tauri\node_modules\vite\node_modules\esbuild\lib\main.js:1353:9
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

For some reason it breaks resolving valibot, but I am not using valibot resolver.

Reproducer

https://stackblitz.com/edit/primevue-nuxt-issue-template-192m3f?file=app.vue

PrimeVue version

4.2.0

Vue version

4.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

No response

Steps to reproduce the behavior

Open reproduce or "edit in stackblitz" from form resolvers docs.

Expected behavior

No response

@25Das 25Das added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 1, 2024
@mertsincan mertsincan self-assigned this Nov 1, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 1, 2024
@mertsincan mertsincan added this to the 4.2.1 milestone Nov 1, 2024
@mertsincan
Copy link
Member

Thanks a lot for your report! I'll check and get back to you

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 1, 2024
@mertsincan mertsincan added the Package: Forms name: @primevue/forms label Nov 1, 2024
@mertsincan
Copy link
Member

PrimeVue 4.2.1 Released 🚀 Please try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Forms name: @primevue/forms Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants