Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miss the pass-though prop named mask in the ConfirmDialog component #7204

Closed
4 tasks
wangziling opened this issue Feb 6, 2025 · 0 comments · Fixed by #7205
Closed
4 tasks

miss the pass-though prop named mask in the ConfirmDialog component #7204

wangziling opened this issue Feb 6, 2025 · 0 comments · Fixed by #7205
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.3.0

Comments

@wangziling
Copy link
Contributor

Describe the bug

Miss the pass-though prop named mask in the ConfirmDialog component.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-hkkszhng?file=src%2FApp.vue

Environment

primevue@4.2.5
vue@3.5.13

Vue version

3.5.13

PrimeVue version

4.2.5

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Use ConfirmDialog component of the primevue package.
  2. Specify a pass through prop named mask.
  3. If the application is using the typescript related techs, the pass-through variable itself will show a warning that the mask prop is nonexistent.

Expected behavior

No errors for specifying the mask pass-through prop for the ConfirmDialog component
@wangziling wangziling added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 6, 2025
@wangziling wangziling mentioned this issue Feb 6, 2025
Merged
@tugcekucukoglu tugcekucukoglu self-assigned this Feb 6, 2025
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 6, 2025
@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Feb 6, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Feb 6, 2025
@tugcekucukoglu tugcekucukoglu moved this from Review to Done in PrimeVue Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeVue
Status: Done
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

fix(confirmdialog): fix the missing of the pass-though prop named mask wangziling/primevue
2 participants
@wangziling @tugcekucukoglu