Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router support for PanelMenu headers #949

Closed
scottix opened this issue Feb 7, 2021 · 2 comments
Closed

Router support for PanelMenu headers #949

scottix opened this issue Feb 7, 2021 · 2 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@scottix
Copy link

scottix commented Feb 7, 2021

Summary

PanelMenu is not using router-link and only providing the url option. Which is odd because it seems PanelMenuSub is using router-link.

Code

<template>
  <PanelMenu :model="menuItems" />
</template>
<script>
import PanelMenu from 'primevue/panelmenu'
export default {
  data() {
    return {
         menuItems: {
          label: 'Activity',
          icon: 'pi pi-book',
          to: '/activity'
        },
    }
  }
}
</script>

Version

3.2.2

Actual Result

Nothing

Expected Result

Provide a router link

@cagataycivici
Copy link
Member

Where exactly do you need router-link?

@scottix
Copy link
Author

scottix commented Feb 17, 2021

Where exactly do you need router-link?

At the top level there is an anchor tag that is not using router-link

https://github.com/primefaces/primevue/blob/3.2.4/src/components/panelmenu/PanelMenu.vue#L6

It should be the same as PanelMenuSub

https://github.com/primefaces/primevue/blob/3.2.4/src/components/panelmenu/PanelMenuSub.vue#L5

@cagataycivici cagataycivici changed the title PanelMenu not using router-link Router support for PanelMenu headers May 10, 2021
@cagataycivici cagataycivici self-assigned this May 10, 2021
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add priority - low labels May 10, 2021
@cagataycivici cagataycivici added this to the 3.5.0 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants