Light theme diff issues

[zepfietje]

Currently, selections inside a diff don't show in the light theme.
Also, the current line background highlight and highlight of text to show what specifically changed in the diff don't show.

I believe this is a regression, since it used to work correctly.

[jrieken]

Yeah, a regression and the second time it happened: #121.

---

FYI - in VS Code you can install another version and stick to 4.x until this is fixed

[jrieken]

ping @simurai

[simurai]

Originally posted by @ridjis in #240 (comment)

---

From The diff views could be improved a bit in "Light High Contrast". Maybe some colors need to be semi-transparent to still see the selection?

[maxbublik]

Just my 5 cents...
Special highlights for inserted/deleted symbols within modified lines are missing in GitHub Light Default theme.
But the highlights are present in the rest of the themes.

Light Default

Dark Dimmed

Dark Default

[jrieken]

Maybe some colors need to be semi-transparent to still see the selection?

Yes, that's required for some colors. /cc @misolori for advice and maybe also idea how we can enforce this in vs code

[miguelsolorio]

The diff background colors definitely need transparency to let selection + highlights appear, the diffEditor.insertedTextBackground token on GitHub Light Default is @ 100% opacity:

Dimming this can help:

---

But also I think there might be some other issues going on the diff view as highlighting text for added/removed lines are fine when side by side:

but when in the diff view, some of the lines appear to be on separate layers:

This is a related but separate issue so I created microsoft/vscode#142468 to follow up on it.

[zepfietje]

Recently a few others have reported this bug as well (#273, #277). Was wondering what's the status of this issue?

[hediet]

GitHub light default:

GitHub light:

Light (Visual Studio):

As you can see (or not), GitHub light default uses the same color for selections and for added/changed lines.

[simurai]

This should be fixed by #287 and released as 6.2.0.

[zepfietje]

Awesome, thanks @simurai!
Should we wait for that PR to be merged manually?

[simurai]

Should we wait for that PR to be merged manually?

Yes, but 6.2.0 should be live now.

[zepfietje]

Great, thanks for fixing, @simurai!