Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Dark Colorblind theme break point not visible for color blind person #245

Closed
npalm opened this issue Dec 14, 2021 · 1 comment · Fixed by #299
Closed

GitHub Dark Colorblind theme break point not visible for color blind person #245

npalm opened this issue Dec 14, 2021 · 1 comment · Fixed by #299

Comments

@npalm
Copy link

npalm commented Dec 14, 2021

I just have tried the color blind dark theme, which works great. Nice Job! One setting that does not work for me is the color of the breakpoint

image

I think using a light color for the breakpoint would be the best option for the contrast. Since the theme should address color blind people, I think it would be great to find a better default. What worked for me was overriding the theme in the settings file.

{
        "workbench.colorCustomizations": {
            "debugIcon.breakpointForeground": "#000000"
        }
}
@simurai
Copy link
Contributor

simurai commented Jul 14, 2022

This PR #299 might improve the breakpoint icon for the colorblind themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants