Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] repo-pull has incorrect border width #814

Closed
thien-do opened this issue Aug 6, 2022 · 4 comments
Closed

[Bug] repo-pull has incorrect border width #814

thien-do opened this issue Aug 6, 2022 · 4 comments
Assignees
@gavinmn
Labels
octicon type: bug 🐞

Comments

@thien-do
Copy link

thien-do commented Aug 6, 2022

Describe the bug

Repo pull icon has 1px width, not 1.5:

image

Steps to reproduce

https://primer.style/octicons/repo-pull-16
@thien-do thien-do changed the title [Bug] [Bug] repo-pull has incorrect border width Aug 6, 2022
@ashygee
Copy link
Contributor

ashygee commented Aug 16, 2022

@thien-do thanks for this issue. The repo-pull icon needs to be redrawn to follow our design guidelines so we will add this to our backlog.

@gavinmn gavinmn self-assigned this Feb 22, 2023
@Daeraxa
Copy link

Daeraxa commented Jul 4, 2023

Just to add to this repo-clone (https://primer.style/design/foundations/icons/repo-clone-16) seems to also be using the older style

@Ninja-mann07
Copy link

ok

@gavinmn
Copy link
Contributor

gavinmn commented Aug 14, 2023

I believe this PR should have addressed this issue #970

@gavinmn gavinmn closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinmn gavinmn

Labels
octicon type: bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@edokoa @thien-do @ashygee @Daeraxa @gavinmn @Ninja-mann07