Skip to content

Commit

Permalink
chore(deps-dev): bump @types/react from 18.2.21 to 18.2.45 (#4074)
Browse files Browse the repository at this point in the history
* chore(deps-dev): bump @types/react from 18.2.21 to 18.2.45

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.21 to 18.2.45.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(Select): add placeholder prop

* chore: add changeset

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
  • Loading branch information
dependabot[bot] and joshblack authored Dec 19, 2023
1 parent d2724df commit 06c7c6c
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/tame-pandas-tie.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Update types for Select to include `placeholder`
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
"@types/lodash.isobject": "3.0.7",
"@types/lodash.keyby": "4.6.7",
"@types/node": "20.10.3",
"@types/react": "18.2.21",
"@types/react": "18.2.45",
"@types/react-dom": "18.2.6",
"@types/semver": "7.5.3",
"@types/styled-components": "^5.1.26",
Expand Down
4 changes: 3 additions & 1 deletion src/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import {SxProp, merge, BetterSystemStyleObject} from './sx'
export type SelectProps = Omit<
Omit<React.ComponentPropsWithoutRef<'select'>, 'size'> & Omit<StyledWrapperProps, 'variant'>,
'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as'
>
> & {
placeholder?: string
}

const arrowRightOffset = '4px'

Expand Down
4 changes: 3 additions & 1 deletion src/Select/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import TextInputWrapper, {StyledWrapperProps} from '../internal/components/TextI
export type SelectProps = Omit<
Omit<React.ComponentPropsWithoutRef<'select'>, 'size'> & Omit<StyledWrapperProps, 'variant'>,
'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as'
>
> & {
placeholder?: string
}

const arrowRightOffset = '4px'

Expand Down

0 comments on commit 06c7c6c

Please sign in to comment.