diff --git a/.changeset/tame-pandas-tie.md b/.changeset/tame-pandas-tie.md new file mode 100644 index 00000000000..bbf010de6db --- /dev/null +++ b/.changeset/tame-pandas-tie.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Update types for Select to include `placeholder` diff --git a/package-lock.json b/package-lock.json index 7963f0b1006..8b0a99a8b2f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -92,7 +92,7 @@ "@types/lodash.isobject": "3.0.7", "@types/lodash.keyby": "4.6.7", "@types/node": "20.10.3", - "@types/react": "18.2.21", + "@types/react": "18.2.45", "@types/react-dom": "18.2.6", "@types/semver": "7.5.3", "@types/styled-components": "^5.1.26", @@ -13618,9 +13618,9 @@ "dev": true }, "node_modules/@types/react": { - "version": "18.2.21", - "resolved": "https://registry.npmjs.org/@types/react/-/react-18.2.21.tgz", - "integrity": "sha512-neFKG/sBAwGxHgXiIxnbm3/AAVQ/cMRS93hvBpg8xYRbeQSPVABp9U2bRnPf0iI4+Ucdv3plSxKK+3CW2ENJxA==", + "version": "18.2.45", + "resolved": "https://registry.npmjs.org/@types/react/-/react-18.2.45.tgz", + "integrity": "sha512-TtAxCNrlrBp8GoeEp1npd5g+d/OejJHFxS3OWmrPBMFaVQMSN0OFySozJio5BHxTuTeug00AVXVAjfDSfk+lUg==", "dependencies": { "@types/prop-types": "*", "@types/scheduler": "*", diff --git a/package.json b/package.json index 364a6005e0e..5774fc5b36e 100644 --- a/package.json +++ b/package.json @@ -177,7 +177,7 @@ "@types/lodash.isobject": "3.0.7", "@types/lodash.keyby": "4.6.7", "@types/node": "20.10.3", - "@types/react": "18.2.21", + "@types/react": "18.2.45", "@types/react-dom": "18.2.6", "@types/semver": "7.5.3", "@types/styled-components": "^5.1.26", diff --git a/src/Select.tsx b/src/Select.tsx index 74c9d4608fb..f1297f94650 100644 --- a/src/Select.tsx +++ b/src/Select.tsx @@ -6,7 +6,9 @@ import {SxProp, merge, BetterSystemStyleObject} from './sx' export type SelectProps = Omit< Omit, 'size'> & Omit, 'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as' -> +> & { + placeholder?: string +} const arrowRightOffset = '4px' diff --git a/src/Select/Select.tsx b/src/Select/Select.tsx index 36bcdb33fbd..247aae714eb 100644 --- a/src/Select/Select.tsx +++ b/src/Select/Select.tsx @@ -5,7 +5,9 @@ import TextInputWrapper, {StyledWrapperProps} from '../internal/components/TextI export type SelectProps = Omit< Omit, 'size'> & Omit, 'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as' -> +> & { + placeholder?: string +} const arrowRightOffset = '4px'