Skip to content

Commit

Permalink
Move the Blankslate css modules feature flag to ga (#4923)
Browse files Browse the repository at this point in the history
* Promote Blankslate to ga feature flag

* Create six-owls-walk.md
  • Loading branch information
jonrohan authored Sep 5, 2024
1 parent a17e689 commit 1dded73
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 11 deletions.
5 changes: 5 additions & 0 deletions .changeset/six-owls-walk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Move the Blankslate css modules feature flag to primer_react_css_modules_ga
10 changes: 5 additions & 5 deletions e2e/components/Blankslate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ test.describe('Blankslate', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_staff: true,
primer_react_css_modules_ga: true,
},
},
})
Expand All @@ -67,7 +67,7 @@ test.describe('Blankslate', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_staff: false,
primer_react_css_modules_ga: false,
},
},
})
Expand All @@ -82,7 +82,7 @@ test.describe('Blankslate', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_staff: true,
primer_react_css_modules_ga: true,
},
},
})
Expand All @@ -108,7 +108,7 @@ test.describe('Blankslate', () => {
id: story.id,
globals: {
featureFlags: {
primer_react_css_modules_staff: true,
primer_react_css_modules_ga: true,
},
},
})
Expand All @@ -126,7 +126,7 @@ test.describe('Blankslate', () => {
id: story.id,
globals: {
featureFlags: {
primer_react_css_modules_staff: false,
primer_react_css_modules_ga: false,
},
},
})
Expand Down
12 changes: 6 additions & 6 deletions packages/react/src/Blankslate/Blankslate.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const BlankslateContainerQuery = `
`

function Blankslate({border, children, narrow, spacious, className}: BlankslateProps) {
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')

if (enabled) {
return (
Expand Down Expand Up @@ -170,7 +170,7 @@ function Blankslate({border, children, narrow, spacious, className}: BlankslateP
export type VisualProps = React.PropsWithChildren

function Visual({children}: VisualProps) {
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')
return (
<span
className={clsx('Blankslate-Visual', {
Expand All @@ -187,7 +187,7 @@ export type HeadingProps = React.PropsWithChildren<{
}>

function Heading({as: Component = 'h2', children}: HeadingProps) {
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')

if (enabled) {
return <Component className={clsx('Blankslate-Heading', classes.Heading)}>{children}</Component>
Expand All @@ -203,7 +203,7 @@ function Heading({as: Component = 'h2', children}: HeadingProps) {
export type DescriptionProps = React.PropsWithChildren

function Description({children}: DescriptionProps) {
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')
return (
<p
className={clsx('Blankslate-Description', {
Expand All @@ -220,7 +220,7 @@ export type PrimaryActionProps = React.PropsWithChildren<{
}>

function PrimaryAction({children, href}: PrimaryActionProps) {
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')
return (
<div
className={clsx('Blankslate-Action', {
Expand All @@ -239,7 +239,7 @@ export type SecondaryActionProps = React.PropsWithChildren<{
}>

function SecondaryAction({children, href}: SecondaryActionProps) {
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')
return (
<div
className={clsx('Blankslate-Action', {
Expand Down

0 comments on commit 1dded73

Please sign in to comment.