From 1dded73ea13dca380cf201e9789bb0338689acc8 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Thu, 5 Sep 2024 11:33:00 -0700 Subject: [PATCH] Move the Blankslate css modules feature flag to ga (#4923) * Promote Blankslate to ga feature flag * Create six-owls-walk.md --- .changeset/six-owls-walk.md | 5 +++++ e2e/components/Blankslate.test.ts | 10 +++++----- packages/react/src/Blankslate/Blankslate.tsx | 12 ++++++------ 3 files changed, 16 insertions(+), 11 deletions(-) create mode 100644 .changeset/six-owls-walk.md diff --git a/.changeset/six-owls-walk.md b/.changeset/six-owls-walk.md new file mode 100644 index 00000000000..766ab44e6b5 --- /dev/null +++ b/.changeset/six-owls-walk.md @@ -0,0 +1,5 @@ +--- +"@primer/react": minor +--- + +Move the Blankslate css modules feature flag to primer_react_css_modules_ga diff --git a/e2e/components/Blankslate.test.ts b/e2e/components/Blankslate.test.ts index 0448ffca341..85e2a749529 100644 --- a/e2e/components/Blankslate.test.ts +++ b/e2e/components/Blankslate.test.ts @@ -52,7 +52,7 @@ test.describe('Blankslate', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: true, + primer_react_css_modules_ga: true, }, }, }) @@ -67,7 +67,7 @@ test.describe('Blankslate', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: false, + primer_react_css_modules_ga: false, }, }, }) @@ -82,7 +82,7 @@ test.describe('Blankslate', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: true, + primer_react_css_modules_ga: true, }, }, }) @@ -108,7 +108,7 @@ test.describe('Blankslate', () => { id: story.id, globals: { featureFlags: { - primer_react_css_modules_staff: true, + primer_react_css_modules_ga: true, }, }, }) @@ -126,7 +126,7 @@ test.describe('Blankslate', () => { id: story.id, globals: { featureFlags: { - primer_react_css_modules_staff: false, + primer_react_css_modules_ga: false, }, }, }) diff --git a/packages/react/src/Blankslate/Blankslate.tsx b/packages/react/src/Blankslate/Blankslate.tsx index a9ada9f24c6..60e1b93e37b 100644 --- a/packages/react/src/Blankslate/Blankslate.tsx +++ b/packages/react/src/Blankslate/Blankslate.tsx @@ -129,7 +129,7 @@ const BlankslateContainerQuery = ` ` function Blankslate({border, children, narrow, spacious, className}: BlankslateProps) { - const enabled = useFeatureFlag('primer_react_css_modules_staff') + const enabled = useFeatureFlag('primer_react_css_modules_ga') if (enabled) { return ( @@ -170,7 +170,7 @@ function Blankslate({border, children, narrow, spacious, className}: BlankslateP export type VisualProps = React.PropsWithChildren function Visual({children}: VisualProps) { - const enabled = useFeatureFlag('primer_react_css_modules_staff') + const enabled = useFeatureFlag('primer_react_css_modules_ga') return ( function Heading({as: Component = 'h2', children}: HeadingProps) { - const enabled = useFeatureFlag('primer_react_css_modules_staff') + const enabled = useFeatureFlag('primer_react_css_modules_ga') if (enabled) { return {children} @@ -203,7 +203,7 @@ function Heading({as: Component = 'h2', children}: HeadingProps) { export type DescriptionProps = React.PropsWithChildren function Description({children}: DescriptionProps) { - const enabled = useFeatureFlag('primer_react_css_modules_staff') + const enabled = useFeatureFlag('primer_react_css_modules_ga') return (

function PrimaryAction({children, href}: PrimaryActionProps) { - const enabled = useFeatureFlag('primer_react_css_modules_staff') + const enabled = useFeatureFlag('primer_react_css_modules_ga') return (

function SecondaryAction({children, href}: SecondaryActionProps) { - const enabled = useFeatureFlag('primer_react_css_modules_staff') + const enabled = useFeatureFlag('primer_react_css_modules_ga') return (