From 32c4fe1441e2f0d4f71ba5c6c75fe0c654908063 Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Fri, 22 Nov 2024 19:11:48 -0500 Subject: [PATCH] Improve the click area for horizontal FormControls (checkboxes and radios) (#5190) * improves the click area for horizontal FormControls (checkboxes and radios) * adds changeset * test(vrt): update snapshots * move padding from just 'label' to all children * test(vrt): update snapshots --------- Co-authored-by: mperrotti --- .changeset/few-baboons-pump.md | 5 +++++ ...-Visually-Hidden-dark-colorblind-linux.png | Bin 10489 -> 9190 bytes ...kbox-Visually-Hidden-dark-dimmed-linux.png | Bin 10306 -> 9011 bytes ...sually-Hidden-dark-high-contrast-linux.png | Bin 10636 -> 9316 bytes .../Checkbox-Visually-Hidden-dark-linux.png | Bin 10489 -> 9190 bytes ...-Visually-Hidden-dark-tritanopia-linux.png | Bin 10489 -> 9190 bytes ...lly-Hidden-focus-dark-colorblind-linux.png | Bin 11094 -> 9776 bytes ...isually-Hidden-focus-dark-dimmed-linux.png | Bin 10940 -> 9593 bytes ...-Hidden-focus-dark-high-contrast-linux.png | Bin 11246 -> 9887 bytes ...ckbox-Visually-Hidden-focus-dark-linux.png | Bin 11094 -> 9776 bytes ...lly-Hidden-focus-dark-tritanopia-linux.png | Bin 11094 -> 9776 bytes ...ly-Hidden-focus-light-colorblind-linux.png | Bin 11123 -> 9770 bytes ...Hidden-focus-light-high-contrast-linux.png | Bin 11176 -> 9811 bytes ...kbox-Visually-Hidden-focus-light-linux.png | Bin 11123 -> 9770 bytes ...ly-Hidden-focus-light-tritanopia-linux.png | Bin 11123 -> 9770 bytes ...Visually-Hidden-light-colorblind-linux.png | Bin 10555 -> 9244 bytes ...ually-Hidden-light-high-contrast-linux.png | Bin 10586 -> 9259 bytes .../Checkbox-Visually-Hidden-light-linux.png | Bin 10555 -> 9244 bytes ...Visually-Hidden-light-tritanopia-linux.png | Bin 10555 -> 9244 bytes ...box-With-Caption-dark-colorblind-linux.png | Bin 8319 -> 7211 bytes ...heckbox-With-Caption-dark-dimmed-linux.png | Bin 8318 -> 7215 bytes ...-With-Caption-dark-high-contrast-linux.png | Bin 8324 -> 7213 bytes .../Checkbox-With-Caption-dark-linux.png | Bin 8319 -> 7211 bytes ...box-With-Caption-dark-tritanopia-linux.png | Bin 8319 -> 7211 bytes ...th-Caption-focus-dark-colorblind-linux.png | Bin 8887 -> 7755 bytes ...x-With-Caption-focus-dark-dimmed-linux.png | Bin 8899 -> 7741 bytes ...Caption-focus-dark-high-contrast-linux.png | Bin 8897 -> 7763 bytes ...Checkbox-With-Caption-focus-dark-linux.png | Bin 8887 -> 7755 bytes ...th-Caption-focus-dark-tritanopia-linux.png | Bin 8887 -> 7755 bytes ...h-Caption-focus-light-colorblind-linux.png | Bin 8877 -> 7706 bytes ...aption-focus-light-high-contrast-linux.png | Bin 8880 -> 7721 bytes ...heckbox-With-Caption-focus-light-linux.png | Bin 8877 -> 7706 bytes ...h-Caption-focus-light-tritanopia-linux.png | Bin 8877 -> 7706 bytes ...ox-With-Caption-light-colorblind-linux.png | Bin 8334 -> 7216 bytes ...With-Caption-light-high-contrast-linux.png | Bin 8314 -> 7201 bytes .../Checkbox-With-Caption-light-linux.png | Bin 8334 -> 7216 bytes ...ox-With-Caption-light-tritanopia-linux.png | Bin 8334 -> 7216 bytes ...dio-With-Caption-dark-colorblind-linux.png | Bin 8587 -> 7449 bytes .../Radio-With-Caption-dark-dimmed-linux.png | Bin 8575 -> 7446 bytes ...-With-Caption-dark-high-contrast-linux.png | Bin 8591 -> 7457 bytes .../Radio-With-Caption-dark-linux.png | Bin 8587 -> 7449 bytes ...dio-With-Caption-dark-tritanopia-linux.png | Bin 8587 -> 7449 bytes ...io-With-Caption-light-colorblind-linux.png | Bin 8609 -> 7467 bytes ...With-Caption-light-high-contrast-linux.png | Bin 8598 -> 7456 bytes .../Radio-With-Caption-light-linux.png | Bin 8609 -> 7467 bytes ...io-With-Caption-light-tritanopia-linux.png | Bin 8609 -> 7467 bytes .../react/src/FormControl/FormControl.tsx | 2 +- 47 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/few-baboons-pump.md diff --git a/.changeset/few-baboons-pump.md b/.changeset/few-baboons-pump.md new file mode 100644 index 00000000000..1d6725bda90 --- /dev/null +++ b/.changeset/few-baboons-pump.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Changes `