fix tests

primer · Sep 25, 2024 · 41bfb14 · 41bfb14
1 parent fa1c4f3
commit 41bfb14
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 17 deletions.
diff --git a/packages/react/src/Details/__tests__/Details.test.tsx b/packages/react/src/Details/__tests__/Details.test.tsx
@@ -41,9 +41,7 @@ describe('Details', () => {
       const {getDetailsProps, open} = useDetails({closeOnOutsideClick: true})
       return (
         <Details {...getDetailsProps()} data-testid="details">
-          <Button as="summary" data-testid="summary">
-            {open ? 'Open' : 'Closed'}
-          </Button>
+          <summary data-testid="summary">{open ? 'Open' : 'Closed'}</summary>
         </Details>
       )
     }
@@ -63,9 +61,7 @@ describe('Details', () => {
       const {getDetailsProps, setOpen, open} = useDetails({closeOnOutsideClick: true, defaultOpen: true})
       return (
         <Details {...getDetailsProps()} data-testid="details">
-          <Button as="summary" data-testid="summary">
-            {open ? 'Open' : 'Closed'}
-          </Button>
+          <summary data-testid="summary">{open ? 'Open' : 'Closed'}</summary>
           <CloseButton onClick={() => setOpen(false)}>Close</CloseButton>
         </Details>
       )
@@ -85,9 +81,7 @@ describe('Details', () => {
       const {getDetailsProps, open} = useDetails({closeOnOutsideClick: true, defaultOpen: true})
       return (
         <Details {...getDetailsProps()}>
-          <Button as="summary" data-testid="summary">
-            {open ? 'Open' : 'Closed'}
-          </Button>
+          <summary data-testid="summary">{open ? 'Open' : 'Closed'}</summary>
           <Box>
             <Button variant="primary">test</Button>
           </Box>

diff --git a/packages/react/src/Overlay/Overlay.test.tsx b/packages/react/src/Overlay/Overlay.test.tsx
@@ -66,19 +66,19 @@ describe('Overlay', () => {
 
   it('should focus element passed into function', async () => {
     const user = userEvent.setup()
-    const {getByText} = render(<TestComponent initialFocus="button" />)
-    await user.click(getByText('open overlay'))
-    await waitFor(() => getByText('Confirm'))
-    const confirmButton = getByText('Confirm')
+    const {getByRole} = render(<TestComponent initialFocus="button" />)
+    await user.click(getByRole('button', {name: 'open overlay'}))
+    await waitFor(() => getByRole('button', {name: 'Confirm'}))
+    const confirmButton = getByRole('button', {name: 'Confirm'})
     expect(document.activeElement).toEqual(confirmButton)
   })
 
   it('should focus first element when nothing is passed', async () => {
     const user = userEvent.setup()
-    const {getByText} = render(<TestComponent />)
-    await user.click(getByText('open overlay'))
-    await waitFor(() => getByText('Cancel'))
-    const cancelButton = getByText('Cancel')
+    const {getByRole} = render(<TestComponent />)
+    await user.click(getByRole('button', {name: 'open overlay'}))
+    await waitFor(() => getByRole('button', {name: 'Cancel'}))
+    const cancelButton = getByRole('button', {name: 'Cancel'})
     expect(document.activeElement).toEqual(cancelButton)
   })