Skip to content

Commit

Permalink
Fix MarkdownEditor fullHeight support (#3893)
Browse files Browse the repository at this point in the history
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
  • Loading branch information
stkao05 and siddharthkp authored Nov 8, 2023
1 parent 988b297 commit a4006e2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/gorgeous-dolphins-compare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Fix MarkdownEditor fullHeight support
2 changes: 1 addition & 1 deletion src/drafts/MarkdownEditor/MarkdownEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ const MarkdownEditor = forwardRef<MarkdownEditorHandle, MarkdownEditorProps>(
<fieldset
aria-disabled={disabled /* if we set disabled={true}, we can't enable the buttons that should be enabled */}
aria-describedby={describedBy ? `${descriptionId} ${describedBy}` : descriptionId}
style={{appearance: 'none', border: 'none', minInlineSize: 'auto'}}
style={{appearance: 'none', border: 'none', minInlineSize: 'auto', height: fullHeight ? '100%' : undefined}}
>
<FormattingTools ref={formattingToolsRef} forInputId={id} />
<div style={{display: 'none'}}>{childrenWithoutSlots}</div>
Expand Down

0 comments on commit a4006e2

Please sign in to comment.