Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Outline variant hover border is not applied correctly #2392

Closed
mijpeterson opened this issue Sep 30, 2022 · 0 comments · Fixed by #2393
Closed

Button: Outline variant hover border is not applied correctly #2392

mijpeterson opened this issue Sep 30, 2022 · 0 comments · Fixed by #2393
Labels
bug Something isn't working react

Comments

@mijpeterson
Copy link

mijpeterson commented Sep 30, 2022

Description

"outline" variant Buttons, on hover, do not apply the theme's hoverBorder color.
image

This is likely due to a typo inside the Button styles file: https://github.com/primer/react/blob/main/src/Button/styles.ts#L135

That line is currently written as:

borderColor: 'outline.hoverBorder',

when it should probably be written as:

borderColor: 'btn.outline.hoverBorder',

Steps to reproduce

  1. Navigate to https://codesandbox.io/s/twilight-fire-1qpyl1?file=/src/App.js
  2. Open the dev tools and inspect the button
  3. Simulate the hover state on the button
  4. Observe the button's CSS property:
    image

Version

35.10.0

Browser

Edge

@mijpeterson mijpeterson added the bug Something isn't working label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants