Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to style Select with sx prop #3599

Closed
robaish opened this issue Aug 7, 2023 · 4 comments · Fixed by #3888
Closed

Unable to style Select with sx prop #3599

robaish opened this issue Aug 7, 2023 · 4 comments · Fixed by #3888
Assignees
Labels
bug Something isn't working component: Select react

Comments

@robaish
Copy link

robaish commented Aug 7, 2023

Description

Hi! I'm unable to style the Select component with the sx prop as follows:

<Select sx={{ borderRadius: '4px', border: '1px solid #eee' }}>

Looking at the component, it's border-radius is set to inherit, but shouldn't the sx prop override styling?

Steps to reproduce

  1. Import Select from @primer/react
  2. Style with sx prop
  3. See no change

Version

v35.26.1

Browser

Chrome

@robaish robaish added the bug Something isn't working label Aug 7, 2023
@joshblack joshblack added bug Something isn't working component: Select and removed bug Something isn't working labels Aug 8, 2023
@lesliecdubs
Copy link
Member

Thanks for reporting, @robaish!

@radglob would you be willing to take a quick look into this and see why sx isn't getting applied on Select? We think it might be a straightforward fix that the prop just isn't getting passed down.

@robaish
Copy link
Author

robaish commented Aug 23, 2023

Thanks @lesliecdubs ! 🙏

@Nagendra88688
Copy link

Hi @lesliecdubs ,
Is this issue solved or should I pick this task ?
Please let me know.

@lesliecdubs
Copy link
Member

@Nagendra88688 I believe this issue is still outstanding. I would invite you to review the contribution docs if you'd like to try contributing a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: Select react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants