Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to Button display cause white space in text to collapse #3612

Closed
joshblack opened this issue Aug 9, 2023 · 0 comments · Fixed by #3613
Closed

Changes to Button display cause white space in text to collapse #3612

joshblack opened this issue Aug 9, 2023 · 0 comments · Fixed by #3613
Labels
react

Comments

@joshblack
Copy link
Member

joshblack commented Aug 9, 2023 •
edited
Loading

Description

A recent change to the styles of the Button component causes white space to collapse when the contents include a mix of text and an element due to usage of display: flex

Steps to reproduce

  1. Head to the button docs

  2. Edit an example to include the markup

    <Button>Default <span>hello</span></Button>

  3. Observe the white space between Default and hello has collapsed

Version

35.27.0

Browser

No response

Additional Context
@joshblack joshblack added bug Something isn't working react component: Button Issues related to the Button component labels Aug 9, 2023
@langermank langermank mentioned this issue Aug 9, 2023
Merged
7 tasks
@joshblack joshblack mentioned this issue Aug 10, 2023
Merged
@lesliecdubs lesliecdubs removed bug Something isn't working component: Button Issues related to the Button component labels Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug] Remove flex from Button labels primer/react
2 participants
@joshblack @lesliecdubs