Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double focus outline appearing on MarkdownEditor #3997

Closed
joshblack opened this issue Dec 1, 2023 · 2 comments
Closed

Double focus outline appearing on MarkdownEditor #3997

joshblack opened this issue Dec 1, 2023 · 2 comments
Labels
bug Something isn't working component: MarkdownEditor react

Comments

@joshblack
Copy link
Member

Description

When editing a markdown editor in React, there are two focus outlines present

Steps to reproduce

Focus a markdown editor in React and observe the two focus outlines present

Version

v36.3.0

Browser

No response
@joshblack joshblack added bug Something isn't working component: MarkdownEditor labels Dec 1, 2023
@iansan5653
Copy link
Contributor

Based on the recent changes to the PVC component, I think the goal here should be to only show the inner outline (the one on the textarea element itself). We may also want to add some margin but that's not directly related to this bug.

PVC commentbox component, focused

@joshblack joshblack mentioned this issue Dec 1, 2023
Merged
@dipree dipree mentioned this issue Dec 4, 2023
Merged
12 tasks
@joshblack joshblack mentioned this issue Dec 4, 2023
Closed
@joshblack
Copy link
Member Author

Issue addressed by revert and fixed in #4008

Opened up: #4017 for the visual change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component: MarkdownEditor react
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iansan5653 @joshblack