Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for className to <AnchoredOverlay> #4739

Closed
sampart opened this issue Jul 15, 2024 · 3 comments · Fixed by #4741
Closed

Add support for className to <AnchoredOverlay> #4739

sampart opened this issue Jul 15, 2024 · 3 comments · Fixed by #4741
Labels
good first issue Good for newcomers react staff Author is a staff member

Comments

@sampart
Copy link
Contributor

sampart commented Jul 15, 2024

At present, <AnchoredOverlay> can't be assigned classes. This means that styling can't be applied to the associated overlay.

In our case, we needed to adjust its z-index, for example.
@sampart sampart added the staff Author is a staff member label Jul 15, 2024
@broccolinisoup broccolinisoup added the good first issue Good for newcomers label Jul 15, 2024
@broccolinisoup
Copy link
Member

Hello @sampart 👋 Thanks for raising this issue. We agree that AnchoredOverlay should have support for className as same as our other components do. You are welcome to push a PR (I always appreciate contributions 🙏 ). Otherwise it is in our backlog now and we will get to it. Thanks!

@Princeyadav05 Princeyadav05 mentioned this issue Jul 16, 2024
Merged
13 tasks
@sampart
Copy link
Contributor Author

sampart commented Jul 16, 2024

Thank you! I'm not expecting to get time on this one myself, but I'll keep it in mind.

romanpozdnov added a commit to romanpozdnov/react that referenced this issue Jul 18, 2024
@romanpozdnov
Added className prop to AnchoredOverlay component
b7aa886 
### Description:
- Added `className` prop to allow custom styling of the `AnchoredOverlay` component
- This change addresses issue primer#4739
@romanpozdnov romanpozdnov mentioned this issue Jul 18, 2024
Merged
13 tasks
@romanpozdnov
Copy link
Contributor

Hey everyone!

In the PR above, the relevant changes have been made. Type definitions have been accounted for, and documentation has been updated.

Happy to help out!

broccolinisoup added a commit to Princeyadav05/react that referenced this issue Jul 23, 2024
@broccolinisoup
Merge branch 'main' into feat/primer#4739-Add-support-for-className-t…
c1e0161 
…o-AnchoredOverlay-
github-merge-queue bot pushed a commit that referenced this issue Jul 23, 2024
@romanpozdnov @broccolinisoup
Added className prop to AnchoredOverlay component for custom styling (#…
dfe6d2f 
…4752)

* Added className prop to AnchoredOverlay component

### Description:
- Added `className` prop to allow custom styling of the `AnchoredOverlay` component
- This change addresses issue #4739

* Updated AnchoredOverlay documentation to include className prop

### Description:
- Added `className` prop to `AnchoredOverlay.docs.json`

* add changeset

* Revert "add changeset"

This reverts commit 4a59f6a.

* Updated the code according to PR#4741

### description:
- the previous PR, which also included the necessary changes: #4741
- only the changes to Storybook were kept

---------

Co-authored-by: Armagan Ersoz <broccolinisoup@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers react staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added support for className to <AnchoredOverlay> Princeyadav05/react
3 participants
@broccolinisoup @sampart @romanpozdnov