-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TabNav component to TSX #1029
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/j33o0lus6 |
🦋 Changeset detectedLatest commit: adcb4b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
src/TabNav.tsx
Outdated
const TabNavParent = styled.nav` | ||
${COMMON} | ||
${sx} | ||
` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This felt like a weird thing to do - I was trying to parallel some patterns in src/UnderlineNav.tsx
and I could not get the props for L19 unless I had an existing Parent element here.
This also seems to be producing some console errors in the tests (though they still pass):
Not sure if the tests needs to be adjusted or if trying to pull out a parent like this is just a bad idea?
This PR migrates the
TabNav
component to TypeScript as part of the TypeScript refactor.