Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Dialog component to TypeScript #1060

Merged
merged 7 commits into from
Feb 22, 2021
Merged

Conversation

VanAnderson
Copy link
Contributor

This PR migrates the Dialog component to TypeScript as part of the TypeScript refactor.

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2021

🦋 Changeset detected

Latest commit: 5bbc19a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/3UMEDqqRU4J8xRSFwkhEuMUupQJx
✅ Preview: https://primer-components-git-vananderson-dialog-migration-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview February 19, 2021 21:24 Inactive
@vercel vercel bot temporarily deployed to Preview February 19, 2021 21:27 Inactive
@colebemis colebemis mentioned this pull request Feb 19, 2021
53 tasks
@vercel vercel bot temporarily deployed to Preview February 21, 2021 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview February 21, 2021 23:54 Inactive
@VanAnderson VanAnderson marked this pull request as ready for review February 22, 2021 15:01
@vercel vercel bot temporarily deployed to Preview February 22, 2021 20:54 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just pushed a few updates. Should be ready to merge

src/Dialog.tsx Outdated Show resolved Hide resolved
src/__tests__/__snapshots__/Dialog.tsx.snap Outdated Show resolved Hide resolved
@colebemis colebemis merged commit bc345f4 into main Feb 22, 2021
@colebemis colebemis deleted the VanAnderson/dialog-migration branch February 22, 2021 21:05
@github-actions github-actions bot mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants