Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive flex component #108

Merged
merged 10 commits into from
Jul 20, 2018
Merged

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Jul 3, 2018

fixes #101

The goal is to have responsive flex components. Task list

  • Updating FlexContainer prop mapping to accept responsive arguments and translate into the correct classnames
  • Anything for FlexItems?
  • Responsive display mapping separate from Flex stuff

@emplums emplums mentioned this pull request Jul 19, 2018
5 tasks
@jonrohan jonrohan changed the base branch from master to release-0.0.11-beta July 19, 2018 14:40
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! There are some linting errors that need to be fixed though in order to get the build to pass

@emplums emplums requested a review from shawnbot July 20, 2018 14:54
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's beautiful

@emplums emplums merged commit 016bbc0 into release-0.0.11-beta Jul 20, 2018
@emplums emplums deleted the responsive_flex_component branch July 20, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants