Update tests #227
Merged
Update tests #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
reviewed
Aug 24, 2018
| @@ -57,14 +57,6 @@ describe('Box', () => { | |||
| expect(render(<Box position="relative" />)).toMatchSnapshot() | |||
There was a problem hiding this comment.
I know we haven't touched this, but I would expect this snapshot to look like <div position="relative"> since we moved the position props in #202. This test should go away.
shawnbot
reviewed
Aug 24, 2018
src/__tests__/UtilitySystemProps.js
Outdated
| import {renderStyles} from '../utils/testing' | ||
|
|
||
| // TODO: These components need required props, | ||
| // Not sure how to set default props for required ones |
There was a problem hiding this comment.
We could do two things here:
- Mock
console.error()temporarily to silence the required prop errors. - Set up an object that lists props for each component, e.g.
const testProps = {
OcticonButton: {icon: X, label: ''},
DonutChart: {data: {pending: 1}},
MergeStatus: {state: 'ready'}
}
shawnbot
reviewed
Aug 24, 2018
| @@ -104,6 +104,9 @@ export function withSystemProps(Component, props = COMMON) { | |||
| Wrapped.displayName = Component.displayName | |||
| Object.assign(Wrapped.propTypes, Component.propTypes) | |||
|
|
|||
| // Set what system props we use on this component | |||
| Wrapped.systemProps = props | |||
emplums
commented
Aug 24, 2018
| 'margin-left': `${theme.space[i]}px`, | ||
| 'margin-right': `${theme.space[i]}px`, | ||
| 'margin-top': `${theme.space[i]}px`, | ||
| padding: `${theme.space[i]}px`, |
src/__tests__/UtilitySystemProps.js
Outdated
| /> | ||
| ) | ||
| ).toMatchKeys({ | ||
| margin: `${theme.space[i]}px`, |
There was a problem hiding this comment.
margin is missing quotes here too
src/__tests__/UtilitySystemProps.js
Outdated
| for (const i in theme.colors[color]) { | ||
| expect(renderStyles(<Component bg={`${color}.${i}`} color={`${color}.${i}`} />)).toMatchKeys({ | ||
| 'background-color': theme.colors[color][i], | ||
| color: theme.colors[color][i] |
| @@ -104,6 +104,9 @@ export function withSystemProps(Component, props = COMMON) { | |||
| Wrapped.displayName = Component.displayName | |||
| Object.assign(Wrapped.propTypes, Component.propTypes) | |||
|
|
|||
| // Set what system props we use on this component | |||
| Wrapped.systemProps = props | |||
|
@emplums I think our linting rules only want quotes on keys that require them, so |
|
@shawnbot why doesn't padding require quotes? I feel like I'm missing something 😂 |
added 10 commits
August 24, 2018 16:34
|
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
added 2 commits
August 24, 2018 16:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates pending tests
Closes: #219
If development process was changed:
Description of changes:
Merge Checklist: