-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DonutChart → Donut, DonutSlice → Donut.Slice #269
Conversation
This pull request is automatically deployed with Now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few questions! I'm cool with this method but would like to see what the others think. If everyone is on board let's do a major release next week with this & the Link work in it.
@broccolini @jonrohan do either of you have any thoughts on this? If everyone feels good about this PR we'll use it to model other parent/child components |
@shawnbot I feel good about merging this for now so we can have it in this week's release - was hoping we could discuss this model for parent/child elements as a team so we're all on the same page, maybe for next week's review? |
This is a proposal to help us decide on #166. It renames the
DonutChart
component toDonut
, moves theDonutSlice
component intosrc/Donut.js
, and makes it available asDonut.Slice
. Before:After:
And if this still seems too verbose, we could ditch the Slice component altogether and allow only the
data
prop.