Bug fix: ActionList item label weight and spacing if description exists #3490
Conversation
🦋 Changeset detectedLatest commit: 45d7b83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| fontWeight: slots.description && slots.description.props.variant !== 'block' ? 'bold' : 'normal', | ||
| fontWeight: slots.description ? 'bold' : 'normal', | ||
| marginBlockEnd: | ||
| slots.description && slots.description.props.variant !== 'inline' ? '4px' : undefined, |
There was a problem hiding this comment.
should this be the token space-1 than 4px?
There was a problem hiding this comment.
Can someone let me know what the syntax is meant to look like to access the spacing token here? I couldn't figure it out, gave up and used px 😛
There was a problem hiding this comment.
- slots.description && slots.description.props.variant !== 'inline' ? '4px' : undefined,
+ slots.description && slots.description.props.variant !== 'inline' ? 1 : undefined,unlessssssss, styled-system doesn't understand logical properties like marginBlockEnd, only marginRight because the last release was in 2019 (open issue).
We could figure out how to add support for logical properties in primer/react or we could add '4px' for now and move on. I say 4px and move on. (only for primer, look the other way @maraisr 😛)
There was a problem hiding this comment.
SIGH haha okay, thanks @siddharthkp!
The item label should be bold is there's a description. I think this likely broke at some point recently. Also fixed the spacing between rows.
Screenshots
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.