Use button CSS vars for border-color to support a feature flag
#3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e244b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…eact into btn-border-contrast-tes
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
reviewed
Oct 26, 2023
| @import '@primer/primitives/tokens-next-private/css/functional/themes/dark-dimmed.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/dark-high-contrast.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/dark-tritanopia.css'; | ||
| /* temporarily disabiling these to ensure visual regression tests work on production code |
There was a problem hiding this comment.
do we want to keep these disabled in storybook?
There was a problem hiding this comment.
I'd like to add a toolbar addon to let you toggle them on, like how we have it in Primer View Components Lookbook
There was a problem hiding this comment.
Good idea, should we do that in a different PR though and get this one quickly?
There was a problem hiding this comment.
Yeah totally agree
siddharthkp
reviewed
Oct 26, 2023
| @@ -9,11 +9,11 @@ export const getVariantStyles = (variant: VariantType = 'default', theme?: Theme | |||
| boxShadow: `${theme?.shadows.btn.shadow}, ${theme?.shadows.btn.insetShadow}`, | |||
| '&:hover:not([disabled])': { | |||
| backgroundColor: 'btn.hoverBg', | |||
| borderColor: 'btn.hoverBorder', | |||
| borderColor: `var(--button-default-borderColor-hover, ${theme?.colors.btn.hoverBorder})`, | |||
siddharthkp
reviewed
Oct 26, 2023
| @@ -25,7 +25,7 @@ exports[`ActionMenu renders consistently 1`] = ` | |||
| .c1 { | |||
| border-radius: 6px; | |||
| border: 1px solid; | |||
| border-color: rgba(31,35,40,0.15); | |||
| border-color: var(--button-default-borderColor-rest,rgba(31,35,40,0.15)); | |||
There was a problem hiding this comment.
✅ makes sense, ActionMenu uses Button
This comment was marked as resolved.
This comment was marked as resolved.
siddharthkp
approved these changes
Oct 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no visual change, and is for a test in dotcom where I'm targeting these CSS variables.
Changelog
defaultandoutlineborder colors including a fallbackRollout strategy
Testing & Reviewing
There should be no visual changes in this PR. Check that the visual regression snapshots look normal.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.