Render string passed to ActionMenu.Button ID prop #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5087185 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
pksjce
approved these changes
Nov 2, 2023
siddharthkp
reviewed
Nov 2, 2023
src/ActionMenu/ActionMenu.tsx
Outdated
| @@ -46,8 +46,13 @@ const Menu: React.FC<React.PropsWithChildren<ActionMenuProps>> = ({ | |||
| const onOpen = React.useCallback(() => setCombinedOpenState(true), [setCombinedOpenState]) | |||
| const onClose = React.useCallback(() => setCombinedOpenState(false), [setCombinedOpenState]) | |||
|
|
|||
| const menuButtonChild = React.Children.toArray(children).find( | |||
| child => React.isValidElement<ActionMenuButtonProps>(child) && child.type === MenuButton, | |||
There was a problem hiding this comment.
should we also check for child.type === Anchor? (used for custom anchor)
Optional: We can also move this code down where we check for MenuButton and Anchor, similar to how renderAnchor is set
There was a problem hiding this comment.
Yea, probably. Will update now.
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/2649
Whatever you pass to the
ActionMenu.Button'sidprop will now be rendered instead of a generated ID.Changelog
New
Nothing new
Changed
The
<button>element rendered byActionMenu.Buttonwill now render whatever is passed toActionMenu.Button'sidpropRemoved
Nothing removed
Rollout strategy
Testing & Reviewing
Confirm this doesn't break any of the other automated a11y stuff in ActionMenu
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.