Move DataTable header creation to before updating sort order
#3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ed6f176 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
thyeggman
temporarily deployed
to
github-pages
GitHub Actions
Inactive
thyeggman
changed the title
DataTable header creation before updating sort order
thyeggman
changed the title
DataTable header creation before updating sort orderDataTable header creation to before updating sort order
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
sortRowsmay be called beforeheadersis initialized.sortRowsfilters headers on this line. I just moved the code block up to avoid this issue.Changelog
New
NA
Changed
Removed
NA
Rollout strategy
Testing & Reviewing
Tried a few different iterations of unit tests but I couldn't get one that definitively proved the issue. However, in my own usage of the component, I found that it seems to be related to state change in some way. This is the error that I was seeing:
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.